Overwrite file and line in ValidationException #1499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of how PHP works, when we instantiate an Exception object, the `file` and `line` properties are the file and line where we created the object. That's a desirable behaviour, but there's no value for a user to know that we created an instance of `ValidationException` in the `Validator` class. This commit will overwrite the file and line in the `ValidationException` to where the method `assert()` was called. Note that when running `check()` it will still point to `Validator`, but I decided not to change it, as the method `check()` got deprecated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
=========================================
Coverage 96.56% 96.56%
- Complexity 977 978 +1
=========================================
Files 201 201
Lines 2414 2417 +3
=========================================
+ Hits 2331 2334 +3
Misses 83 83 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how PHP works, when we instantiate an Exception object, the
fileandlineproperties are the file and line where we created the object. That's a desirable behaviour, but there's no value for a user to know that we created an instance ofValidationExceptionin theValidatorclass.This commit will overwrite the file and line in the
ValidationExceptionto where the methodassert()was called.Note that when running
check()it will still point toValidator, but I decided not to change it, as the methodcheck()got deprecated.