Allow Min and Max to wrap chained rules #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
============================================
+ Coverage 96.56% 96.57% +0.01%
- Complexity 978 979 +1
============================================
Files 201 202 +1
Lines 2417 2426 +9
============================================
+ Hits 2334 2343 +9
Misses 83 83 ☔ View full report in Codecov by Sentry. |
This follows the same pattern as the `Length` rule. I've also removed the separate named and standard templates from these rules. I didn't see a good way to implement these in the new pattern, and also felt the language of the old standard template was somewhat difficult to read anyway.
This base class could also be used for other aggregate operations on arrays, e.g. a sum. (It can't be used for `Length` though, as we would not be able to validate a length of 0.).
henriquemoody
force-pushed
the
pr/1501
branch
from
3373d01 to
e465810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1501