Update "Message Translation" documentation#1620
Update "Message Translation" documentation#1620henriquemoody wants to merge 1 commit intoRespect:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1620 +/- ##
=========================================
Coverage 97.93% 97.93%
Complexity 958 958
=========================================
Files 197 197
Lines 2228 2228
=========================================
Hits 2182 2182
Misses 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the "Message Translation" documentation to reflect recent codebase changes, particularly the new ability to pass custom definitions directly to ContainerRegistry::createContainer().
Changes:
- Added optional
$definitionsparameter toContainerRegistry::createContainer()for passing custom container definitions - Improved test coverage with meaningful assertions and added test for new parameter functionality
- Completely rewrote message translation documentation with clearer examples and updated API usage
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ContainerRegistry.php | Added optional $definitions parameter to allow passing custom container definitions, maintaining backward compatibility |
| tests/unit/ContainerRegistryTest.php | Enhanced test with proper assertion replacing DoesNotPerformAssertions attribute and added test coverage for custom definitions feature |
| docs/message-translation.md | Comprehensive rewrite documenting symfony/translation integration, showing new API usage with examples for basic translation, dynamic values, and list modifiers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
henriquemoody
force-pushed
the
docs/translation
branch
4 times, most recently
from
10cb14c to
78c6796
Compare
henriquemoody
force-pushed
the
docs/translation
branch
from
78c6796 to
259e49f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
After many changes to the codebase, this documentation was outdated. Assisted-by: Claude Code (Opus 4.5)
henriquemoody
force-pushed
the
docs/translation
branch
from
259e49f to
b8faef7
Compare
|
Merged manually |
After many changes to the codebase, this documentation was outdated.