Remove now unecessary fallback to json_decode#1637
Merged
alganet merged 1 commit intoRespect:mainfrom Jan 29, 2026
Merged
Conversation
Since PHP 8.3, we don't need that fallback anymore. Now that the library is set to a minimum PHP 8.5, we can safely remove it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
============================================
+ Coverage 98.03% 98.11% +0.08%
+ Complexity 961 960 -1
============================================
Files 197 197
Lines 2234 2231 -3
============================================
- Hits 2190 2189 -1
+ Misses 44 42 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henriquemoody
approved these changes
Jan 28, 2026
Member
Author
|
Thanks! Waiting for #1636 so the CI will run cleaner on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHP 8.3, we don't need that fallback anymore. Now that the library is set to a minimum PHP 8.5, we can safely remove it.