Skip to content

Remove now unecessary fallback to json_decode#1637

Merged
alganet merged 1 commit intoRespect:mainfrom
alganet:json-validate
Jan 29, 2026
Merged

Remove now unecessary fallback to json_decode#1637
alganet merged 1 commit intoRespect:mainfrom
alganet:json-validate

Conversation

@alganet
Copy link
Member

@alganet alganet commented Jan 28, 2026

Since PHP 8.3, we don't need that fallback anymore. Now that the library is set to a minimum PHP 8.5, we can safely remove it.

Since PHP 8.3, we don't need that fallback anymore. Now that the
library is set to a minimum PHP 8.5, we can safely remove it.
@alganet alganet marked this pull request as ready for review January 28, 2026 19:49
@alganet alganet requested a review from henriquemoody January 28, 2026 19:49
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.11%. Comparing base (b69beb1) to head (42cbbf3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1637      +/-   ##
============================================
+ Coverage     98.03%   98.11%   +0.08%     
+ Complexity      961      960       -1     
============================================
  Files           197      197              
  Lines          2234     2231       -3     
============================================
- Hits           2190     2189       -1     
+ Misses           44       42       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alganet
Copy link
Member Author

alganet commented Jan 28, 2026

Thanks! Waiting for #1636 so the CI will run cleaner on main.

@alganet alganet merged commit 0381718 into Respect:main Jan 29, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants