Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ContainerRegistry.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
namespace Respect\Validation;

use DI\Container;
use libphonenumber\PhoneNumberUtil;
use Psr\Container\ContainerInterface;
use Respect\StringFormatter\BypassTranslator;
use Respect\StringFormatter\Modifier;
Expand Down Expand Up @@ -52,6 +53,7 @@ final class ContainerRegistry
public static function createContainer(array $definitions = []): Container
{
return new Container($definitions + [
PhoneNumberUtil::class => factory(static fn() => PhoneNumberUtil::getInstance()),
Transformer::class => create(Prefix::class),
TemplateResolver::class => create(TemplateResolver::class),
TranslatorInterface::class => autowire(BypassTranslator::class),
Expand Down
7 changes: 3 additions & 4 deletions src/Validators/Phone.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
use Respect\Validation\Validator;
use Sokil\IsoCodes\Database\Countries;

use function class_exists;
use function is_scalar;

#[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE)]
Expand All @@ -53,9 +52,9 @@ final class Phone implements Validator

public function __construct(string|null $countryCode = null, Countries|null $countries = null)
{
if (!class_exists(PhoneNumberUtil::class)) {
if (!ContainerRegistry::getContainer()->has(PhoneNumberUtil::class)) {
throw new MissingComposerDependencyException(
'Phone rule libphonenumber for PHP',
'Phone rule requires libphonenumber for PHP',
'giggsey/libphonenumber-for-php',
);
}
Expand Down Expand Up @@ -96,7 +95,7 @@ public function evaluate(mixed $input): Result
private function isValidPhone(string $input): bool
{
try {
$phoneNumberUtil = PhoneNumberUtil::getInstance();
$phoneNumberUtil = ContainerRegistry::getContainer()->get(PhoneNumberUtil::class);
$phoneNumberObject = $phoneNumberUtil->parse($input, $this->country?->getAlpha2());
if ($this->country === null) {
return $phoneNumberUtil->isValidNumber($phoneNumberObject);
Expand Down
38 changes: 36 additions & 2 deletions tests/unit/Validators/PhoneTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
namespace Respect\Validation\Validators;

use DI;
use libphonenumber\PhoneNumberUtil;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Group;
Expand All @@ -26,6 +27,7 @@
use Respect\Validation\Exceptions\InvalidValidatorException;
use Respect\Validation\Exceptions\MissingComposerDependencyException;
use Respect\Validation\Test\TestCase;
use Sokil\IsoCodes\Database\Countries;
use stdClass;

#[Group('validator')]
Expand Down Expand Up @@ -70,10 +72,17 @@ public function itShouldThrowsExceptionWhenCountryCodeIsNotValid(): void
}

#[Test]
public function shouldThrowWhenMissingComponent(): void
public function shouldThrowWhenMissingIsocodesComponent(): void
{
$mainContainer = ContainerRegistry::getContainer();
ContainerRegistry::setContainer((new DI\ContainerBuilder())->useAutowiring(false)->build());
ContainerRegistry::setContainer(
(new DI\ContainerBuilder())
->addDefinitions([
PhoneNumberUtil::class => DI\factory(static fn() => PhoneNumberUtil::getInstance()),
])
->useAutowiring(false)
->build(),
);
try {
new Phone('US');
$this->fail('Expected MissingComposerDependencyException was not thrown.');
Expand All @@ -87,6 +96,31 @@ public function shouldThrowWhenMissingComponent(): void
}
}

#[Test]
public function shouldThrowWhenMissingPhonesComponent(): void
{
$mainContainer = ContainerRegistry::getContainer();
ContainerRegistry::setContainer(
(new DI\ContainerBuilder())
->addDefinitions([
Countries::class => DI\create(Countries::class),
])
->useAutowiring(false)
->build(),
);
try {
new Phone('US');
$this->fail('Expected MissingComposerDependencyException was not thrown.');
} catch (MissingComposerDependencyException $e) {
$this->assertStringContainsString(
'Phone rule requires libphonenumber for PHP.',
$e->getMessage(),
);
} finally {
ContainerRegistry::setContainer($mainContainer);
}
}

/** @return array<array{mixed}> */
public static function providerForValidInputWithoutCountryCode(): array
{
Expand Down
Loading