Skip to content

Conversation

@wescopeland
Copy link
Member

This PR makes an enhancement to SubmitGameTitleAction.

When a developer adds a new "subset game" to the database (a game with a title like 'Some Game [Subset - Bonus]'), the new game's achievement set will automatically be attached to the parent game (if found) with a type of WillBeExclusive.

We intentionally make no attempt whatsoever to try to discern what the set type is, even if the given title for the subset is "Bonus". This is purely meant to make navigation for players on the website less confusing (currently, they're seeing the same game across two game pages because the subset game is commonly orphaned).

@wescopeland wescopeland requested a review from a team December 13, 2025 16:43
Copy link
Member

@Jamiras Jamiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still requires loading a ROM with a unique hash to initiate the client-side game creation UI. Now that we're testing multiset, we may want to imagine a world where a subset can be created without a hash. What would that look like? Would it still go through this API via the client, or would it be something initiated from the filament pages? If the latter, do we even want these changes?

@wescopeland
Copy link
Member Author

Now that we're testing multiset, we may want to imagine a world where a subset can be created without a hash. What would that look like? Would it still go through this API via the client, or would it be something initiated from the filament pages? If the latter, do we even want these changes?

I'm shooting from the hip, but I think a lot of this may boil down to what options we have for managing subsets in the toolkit. It probably is desirable to be able to work on multiple sets simultaneously in the toolkit. Or at the very least, select which set is being actively worked on. I'm not sure what that looks like or how complex it would be to build.

@Jamiras
Copy link
Member

Jamiras commented Dec 15, 2025

I think a lot of this may boil down to what options we have for managing subsets in the toolkit. It probably is desirable to be able to work on multiple sets simultaneously in the toolkit. Or at the very least, select which set is being actively worked on. I'm not sure what that looks like or how complex it would be to build.

Subsets returned by the server should already support create/update operations.

image image image

There's just no way to add new subsets from the toolkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants