-
-
Notifications
You must be signed in to change notification settings - Fork 116
feat(multiset): add 'Enable multiset' toggle for devs to enable multiset for games #4296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(multiset): add 'Enable multiset' toggle for devs to enable multiset for games #4296
Conversation
| AchievementSetType::WillBeSpecialty->value, | ||
| ])->exists()) | ||
| ->label(fn () => $this->hasWillBeTypes($game) ? 'Enable Multiset' : 'Disable Multiset') | ||
| ->icon(fn () => $this->hasWillBeTypes($game) ? 'heroicon-o-play' : 'heroicon-o-pause') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want the play button on the Enable Mulitset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a nice-to-have. When quickly visually scanning the actions, it gives a subtle visual distinction between itself and the attach button.


Should only be merged when it's time to end the multiset beta.
This PR adds an "Enable multiset" toggle button in the game "Sets" tab for users with the Developer role to turn on multiset for a game.
When the button is pressed and the action is confirmed,
will_be_bonusandwill_be_specialtyare flipped tobonusandspecialtyrespectively.will_be_exclusiveis unaffected - this type should be removed altogether for redundancy; devs should be able to directly set a type asexclusiveinstead.Pressing the toggle logs an entry on the game's audit log.