Skip to content

Conversation

@wescopeland
Copy link
Member

@wescopeland wescopeland commented Dec 23, 2025

UPDATE game_achievement_sets
SET type = 'exclusive'
WHERE type = 'will_be_exclusive';

Should only be merged when it's time to end the multiset beta.

This PR adds an "Enable multiset" toggle button in the game "Sets" tab for users with the Developer role to turn on multiset for a game.

When the button is pressed and the action is confirmed, will_be_bonus and will_be_specialty are flipped to bonus and specialty respectively.

will_be_exclusive is unaffected - this type should be removed altogether for redundancy; devs should be able to directly set a type as exclusive instead.

Pressing the toggle logs an entry on the game's audit log.

Screenshot 2025-12-23 at 2 13 00 PM Screenshot 2025-12-23 at 2 18 58 PM Screenshot 2025-12-23 at 2 13 09 PM

@wescopeland wescopeland requested a review from a team December 23, 2025 19:15
AchievementSetType::WillBeSpecialty->value,
])->exists())
->label(fn () => $this->hasWillBeTypes($game) ? 'Enable Multiset' : 'Disable Multiset')
->icon(fn () => $this->hasWillBeTypes($game) ? 'heroicon-o-play' : 'heroicon-o-pause')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pause icon doesn't really look like much of an icon. I wonder if this button would be better without an icon?

Image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it in latest:
Screenshot 2026-01-02 at 4 11 45 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want the play button on the Enable Mulitset?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a nice-to-have. When quickly visually scanning the actions, it gives a subtle visual distinction between itself and the attach button.

@wescopeland wescopeland added the deployment/sql Includes SQL that needs to be run before/after deployment label Jan 2, 2026
@wescopeland wescopeland requested a review from Jamiras January 2, 2026 21:12
@wescopeland wescopeland merged commit 1f19fa4 into RetroAchievements:master Jan 9, 2026
20 checks passed
@wescopeland wescopeland deleted the multiset-toggle branch January 9, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment/sql Includes SQL that needs to be run before/after deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants