Make sure zooming via mouse goes back to 1.0 #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
zoom-factor
branch
from
157585a to
9b57b16
Compare
Flamefire
force-pushed
the
zoom-factor
branch
from
2108e63 to
f78af8c
Compare
Flow86
requested changes
Nov 17, 2025
Contributor
|
works as intended, thanks! :) |
Member
Author
|
@Flow86 Jenkins fails with
|
Flamefire
force-pushed
the
zoom-factor
branch
from
f7c183f to
0d41f96
Compare
Member
yes, already fixed, but I forgot to make it permanent. now it should work |
Zooming in with "z" goes to the next zoom level not potentially the previous and vice versa.
Add a check that snaps the value to 1 if close enough. Fixes Return-To-The-Roots#1822
It shouldn't report an iterator as a pointer even if it happens to be one. Seen in clang-tidy 18, fixed in trunk.
Flamefire
force-pushed
the
zoom-factor
branch
from
0d41f96 to
4072745
Compare
Flow86
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1822
When the zoom factor is closer to 1.0 than the mouse-increment set it to 1
Also make sure that using the keys to zoom behave consistently: If we set a "close" zoom level then either "z" or "Z" would jump to 1 level off the expected.
Example: Zoom in to 1.03, between level 4 and 5. If we set the level to "4" than zooming out will jump to 3 not back to 4. Similar for setting it to 5 and zooming in