Fix song selection in music player window #1834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selecting a start song when the playlist isn't prepared yet isn't possible because the `order` list isn't filled and hence the selected song isn't found. Make sure we prepare it first and add test for that. Fixes Return-To-The-Roots#1833 Update the translations, fixes Return-To-The-Roots#1832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting a start song when the playlist isn't prepared yet isn't possible because the
orderlist isn't filled and hence the selected song isn't found.Make sure we prepare it first and add test for that.
Fixes #1833
Update the translations, fixes #1832