Add option to jump by specific number of GFs to jump window #1862
+105
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flow86
reviewed
Jan 16, 2026
| btSize.x = (availWidth - spacing * (jumpPresets.size() - 1)) / jumpPresets.size(); | ||
| for(auto i : helpers::range(jumpPresets.size())) | ||
| { | ||
| AddTextButton(ID_btJumpPresetStart + i, curPos, btSize, TextureColor::Green1, |
Member
There was a problem hiding this comment.
why not simply + jumpPresets[i]? (e.g iterate over the values)
it doesnt matter how big those ids are or if there are gaps.
Member
|
@Flamefire I'm loving it - except the button texture which is wrong for the 4 lower buttons ;) |
Member
Author
|
I used a different texture for the buttons at the bottom to make them stick out a bit. Can revert it or use another one. Which would you like? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1861
@Spikeone Like this?