Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the BareMetal API and network drivers to improve memory handling, descriptor management, and overall consistency in function definitions. The changes include updates to assembly and C code for network interfaces and system calls, as well as adjustments to constants and function parameters.
BareMetal API Updates:
api/libBareMetal.asmfor functions likeb_output,b_net_tx,b_net_rx,b_nvs_read, andb_nvs_writeto replace "Memory location" with "Memory address" for clarity.MAC_GETtoNET_STATUSand addedNET_CONFIGfor better alignment with network functionality.Network Driver Enhancements:
net_i8254x_init,net_i8257x_init, andnet_i8259x_initto use explicit memory assignments (mov [rdi+nt_*]) instead ofstos*instructions, improving clarity and maintainability. [1] [2] [3]net_*_configfunctions for Intel NIC drivers (i8254x,i8257x,i8259x) to streamline packet storage initialization. [1] [2] [3]i8254x_MAX_DESCandi8257x_MAX_DESCto 2048, standardizing descriptor count across drivers. [1] [2]System Call Adjustments:
b_outputsyscall insrc/syscalls/io.asmto clarify input parameter as "Memory address of message."C Code Refinements:
b_net_rxinapi/libBareMetal.cto ensure proper register assignments (=Dfor memory address and=cfor packet length).