Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes multiple changes to the Intel 8259x NIC driver (
src/drivers/net/i8259x.asm) and related system variables (src/sysvar.asm). The changes primarily focus on improving descriptor management, refining initialization processes, updating comments for clarity, and enhancing the functionality of polling and transmission. Below is a summary of the most important changes:Descriptor Management Updates:
nt_rx_tail) innet_i8259x_initand updated descriptor tail management logic innet_i8259x_poll. This ensures proper handling of RX descriptors during packet reception. [1] [2]Initialization Refinements:
Polling Enhancements:
Code Cleanup and Comment Improvements:
shl eax, 15for multiplying by 32768) and describing register usage during initialization and polling. [1] [2]System Variable Adjustments:
nt_rx_tailandnt_tx_headto 32-bit variables for more efficient descriptor tracking. Added new definitions for RX and TX tail/head insrc/sysvar.asm.