-
Notifications
You must be signed in to change notification settings - Fork 1
Reuben hill/updates #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ReubenHill
wants to merge
72
commits into
main
Choose a base branch
from
ReubenHill/updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has import and export options that do the same thing as the buttons.
Will need to remove handles.atlas_path for new CoordinateTransform function load
Can now specify a list of names. Also fixed the other import menus
Also save warning distance between sessions
Can also now align whenever we have enough points. This will add floating point error each time we do it but it's simpler than faffing about with switching the button off and on or keeping track on an 'aligned' variable
-Fixed some bugs -Shows the output in a command window -To log outputs have to start distribution as administrator if using default install location (can't usually write to program files without admin privilages) -Output log now much more verbose -Turns out settings have not been saving in r2016b when using a binary the whole time so I've (hopefully) fixed that!
- Can now delete a chunk of just measurement data - "Set row location" renamed to "Delete Row Data and Set as Point to Get" such that that is what it does. - Measurements skip over ones which have already been found to avoid accidental overwrites. If you want to change a measurement you use the "Delete Row Data and Set as Point to Get" button. - Undo now actually removes the last measured point (rather than the last point count!)
The "Delete Row Data and Set Point to Get" button has been renamed "Delete Row(s) Coordinates and Set Point to Get". This allows multiple measurements to be deleted at once AND sets the point to measure to be the first row you select. If you only select one row then it behaves as before. The delete rows data toolbar button has been removed.
"Insert Below" is now "Insert Row Below".
Can add multiple rows!
Not allowed to get measurements whilst an unexpected measurement error is open. Also every measurement clears any open "success!" dialogue boxes.
Under a column 'measured'
Also update readme
Double tap no longer adds a new line at the end of measurements, it properly disables measurements, and doesn't add an unticked box. Delete and set rows no longer adds unticked boxes either
Deleting rows now removes points from the point history. Also we now only ungrey atlas alignment if the points are in the point history.
If no location name is specified at some of the locations the import wouldn't work
Still keeps the point, an marks the tick box if it's within tolerance.
Title is 'In tolerance?' with 3 states 'Unmeasured', 'Yes', and 'No'.
'In tolerance?' is now 'As expected?'. Also output the tolerance itself and the l2 distance we are from the expected location.
Note I've renamed "As expected?" to "Is expected" to get rid of question mark. When I save I replace spaces with underscores.
This reverts commit 60d5bde.
Before it only happened at first import.
Go to options/insert to select which
was 'Delete Coordinate Row(s) and Set Point to Get'
Now reads Nomenclature: "Locations" are sets of names given to measurements. "Coordinates" are the X, Y and Z coordinates measured when the stylus button is pressed. "Data" is everything contained in the table. For accurate measurements: Ensure the entire stylus is in the northern measurement hemisphere (the source wire points to the south pole).
was Remove Last Measured Point (Ctrl+Z)
Now warns that atlas locations won't be outputted also. I've also updated the tooltips to be more explicit and stick to my nomenclature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo