[Paywalls V2] Takes application locales into account. #2299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build increased size
TestPurchasesUIAndroidCompatibility 1.0 (1)
|
| Item | Install Size Change | Download Size Change |
|---|---|---|
| resources.arsc | ⬆️ 212.3 kB | ⬆️ 47.8 kB |
| 📝 androidx.appcompat.app.AppCompatDelegateImpl | ⬆️ 19.8 kB | ⬆️ 6.7 kB |
| kotlin.collections.ArraysKt___ArraysKt | ⬇️ -2.2 kB | ⬇️ -6.4 kB |
| 📝 androidx.appcompat.widget.Toolbar | ⬆️ 18.3 kB | ⬆️ 6.2 kB |
| 📝 androidx.appcompat.widget.LinearLayoutCompat | ⬆️ 16.8 kB | ⬆️ 5.7 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
JayShortway
commented
Mar 31, 2025
| override val currentLocalesLanguageTags: String | ||
| get() = LocaleListCompat.getDefault().toLanguageTags() | ||
| get() = (AppCompatDelegate.getApplicationLocales() + LocaleListCompat.getDefault()).distinct().toLanguageTags() |
There was a problem hiding this comment.
This ensures the app-specific locales take precedence in the X-Preferred-Locales header.
JayShortway
commented
Mar 31, 2025
| @@ -87,7 +89,9 @@ internal sealed interface PaywallState { | |||
| private val purchasedNonSubscriptionProductIds: Set<String>, | |||
| private val dateProvider: () -> Date, | |||
| private val packages: AvailablePackages, | |||
| initialLocaleList: LocaleList = LocaleList.current, | |||
| initialLocaleList: LocaleList = LocaleList( | |||
| (AppCompatDelegate.getApplicationLocales().toComposeLocaleList() + LocaleList.current).distinct(), | |||
There was a problem hiding this comment.
This ensures the app-specific locales take precedence on the paywall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafty McDraft