Adds new tab ID properties to TabsComponent.
#2577
Open
+69
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we need to fix paywall tester |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2577 +/- ##
==========================================
- Coverage 78.64% 78.63% -0.01%
==========================================
Files 296 296
Lines 10888 10893 +5
Branches 1520 1520
==========================================
+ Hits 8563 8566 +3
- Misses 1663 1665 +2
Partials 662 662 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JayShortway
commented
Aug 4, 2025
Comment on lines
+28
to
+29
| @SerialName("tab_id") | ||
| val tabId: String, |
There was a problem hiding this comment.
@joshdholtz Just checking, is it correct that this property will always exist in the response?
JayShortway
commented
Aug 4, 2025
Comment on lines
+99
to
+100
| @get:JvmSynthetic | ||
| val id: String, |
There was a problem hiding this comment.
@joshdholtz Same question here, is it correct that this property will always exist in the response?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
tab_id,idanddefault_tab_idproperties to theTabsComponentmodel where necessary. These new properties are not used yet. This makes the same changes to the JSON models as these iOS PRs: