Skip to content

Conversation

RCGitBot
Copy link
Contributor

@RCGitBot RCGitBot commented Aug 3, 2025

This PR contains the following updates:

Package Type Update Change
com.android.library (source) plugin minor 8.11.1 -> 8.13.0
com.android.application (source) plugin minor 8.11.1 -> 8.13.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@RCGitBot RCGitBot added the pr:dependencies Changes on external dependencies label Aug 3, 2025
@RCGitBot RCGitBot requested a review from a team August 3, 2025 00:18
@JayShortway
Copy link
Member

@vegaro @facumenzella This added a new lint rule which flags:

/home/circleci/project/ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/customercenter/InternalCustomerCenter.kt:87: Error: Calls to launch should happen inside a LaunchedEffect and not composition [CoroutineCreationDuringComposition from androidx.compose.runtime]

I think something like this should do it?

+    LaunchedEffect(state) {
        if (state is CustomerCenterState.NotLoaded) {
            coroutineScope.launch {
                viewModel.loadCustomerCenter()
            }
        }
+    }

We should double check if it still behaves exactly the same though. I can see the scope getting cancelled once the state changes to Loading. Maybe we should use LaunchedEffect(state != Success), or just LaunchedEffect(Unit).

@RCGitBot RCGitBot changed the title [RENOVATE] Update build-dependencies to v8.12.0 [RENOVATE] Update build-dependencies to v8.12.1 Aug 24, 2025
@RCGitBot RCGitBot force-pushed the renovate/build-dependencies branch from fae84bf to fca4c34 Compare August 24, 2025 00:16
@tonidero
Copy link
Contributor

@RevenueCat/customer-center could you take a look at @JayShortway's documentation. I think that makes sense but would be good to confirm so we can get this merged in

@RCGitBot RCGitBot changed the title [RENOVATE] Update build-dependencies to v8.12.1 [RENOVATE] Update build-dependencies to v8.12.2 Aug 31, 2025
@RCGitBot RCGitBot force-pushed the renovate/build-dependencies branch from fca4c34 to 0f50297 Compare August 31, 2025 00:16
@RCGitBot RCGitBot changed the title [RENOVATE] Update build-dependencies to v8.12.2 [RENOVATE] Update build-dependencies to v8.13.0 Sep 7, 2025
@RCGitBot RCGitBot force-pushed the renovate/build-dependencies branch from 0f50297 to 93fcaf1 Compare September 7, 2025 00:15
@vegaro
Copy link
Contributor

vegaro commented Sep 9, 2025

Sorry about missing this. Just created #2659

github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2025
Fixes
#2588 (comment)

A new lint issue that starts happening when upgrading to AGP 8.13.0

Also wrapped the `refreshStateIfColorsChanged` in a LaunchedEffect keyed
by the inputs, so it only runs when the theme actually changes.
@vegaro vegaro deleted the renovate/build-dependencies branch September 9, 2025 10:31
tonidero pushed a commit that referenced this pull request Sep 10, 2025
Fixes
#2588 (comment)

A new lint issue that starts happening when upgrading to AGP 8.13.0

Also wrapped the `refreshStateIfColorsChanged` in a LaunchedEffect keyed
by the inputs, so it only runs when the theme actually changes.
@RCGitBot
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (8.13.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:dependencies Changes on external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants