Remove output_style from xcodebuild calls in test_revenuecatui
#5978
+19
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
changed the title
output_style from xcodebuild calls in test_revenuecatui
tonidero
approved these changes
Dec 30, 2025
Contributor
tonidero
left a comment
tonidero
left a comment
There was a problem hiding this comment.
I'm not too familiar with this, but I think it's safe. We can always revert if needed 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept getting hanging tests in #5959 (example)
After looking into it for a while, I removed the
output_style: :basic,from ourxcodebuildcall and they started to pass. Thetest_revenuecatuiCI jobs were timing out with "Too long with no output" errors. The tests were running correctly, but xcpretty was buffering output differently when using output_style: :basic.So far what I understand is that in Fastlane's xcodebuild action
output_style: :basicpasses--no-utfflag to xcpretty, which disables UTF-8 characters (no checkmarks, etc.) and colored output (--no-color). Withoutoutput_style(the default) it usesxcprettywith--colorflag, which enables colored output with ANSI escape codes.At the same time I realized that xcodebuild is always using
xcprettyand we were installing unnecessaryxcbeautify. So I removed the installations from all RevenueCatUI test jobs since the lane uses xcodebuild directly. I tried usingscanbut looks likescandoesn't suppor SPM correctly.I tried with a failing test and things are still working fine.