-
Notifications
You must be signed in to change notification settings - Fork 404
Improve accuracy of transactions origin part 1: Storing transaction metadata #5988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| } | ||
|
|
||
| // MARK: Storing | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: add serialization tests asserting against json snapshots
… of PaywallEvent in metadata
… to PurchasesOrchestrator
a2346cd to
eb74e2d
Compare
3 builds increased size, 1 build had no size change
RevenueCat 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 48.4 kB |
| RevenueCat.Backend.Backend | ⬇️ -5.5 kB |
| RCPurchases.Objc Metadata | ⬆️ 4.8 kB |
| DYLD.Exports | ⬆️ 4.0 kB |
| Code Signature | ⬆️ 3.3 kB |
BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 38.9 kB (0.36%)
Total download size change: ⬆️ 13.3 kB (0.37%)
Largest size changes
| Item | Install Size Change |
|---|---|
| 🗑 RevenueCat.PurchasesOrchestrator.handlePostReceiptResult(transact... | ⬇️ -9.4 kB |
| 📝 RevenueCat.LocalTransactionMetadata.value witness | ⬆️ 5.8 kB |
| RevenueCat.Purchases.restorePurchases(completion) | ⬆️ 4.1 kB |
| 🗑 RevenueCat.PostReceiptDataOperation.Paywall | ⬇️ -3.9 kB |
| DYLD.String Table | ⬆️ 3.7 kB |
BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 88.9 kB (0.37%)
Total download size change: ⬆️ 15.1 kB (0.28%)
Largest size changes
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 34.9 kB |
| 🗑 RevenueCat.PurchasesOrchestrator.handlePostReceiptResult(transact... | ⬇️ -9.4 kB |
| 📝 RevenueCat.LocalTransactionMetadata.value witness | ⬆️ 5.8 kB |
| RevenueCat.Purchases.restorePurchases(completion) | ⬆️ 4.1 kB |
| 🗑 RevenueCat.PostReceiptDataOperation.Paywall | ⬇️ -3.8 kB |
BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm
No changes to report
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded



Based on #5940, this PR focusses on the first part, storing the transaction metadata in a local persistent cache.
Checklist
purchases-androidand hybridsMotivation
Description