Restructure CI with tiered PR checks and release gating #6241

ajpallares · 2026-02-10T10:10:49Z

Motivation

Currently only a subset of tests run on PRs, and the full suite (all-tests) only runs on main/release or via manual trigger. New contributors don't know about the manual trigger, so PRs can be merged without the full test suite passing.

Additionally, on release branches the hold job for tagging a release only requires release-checks to pass — it does not require the full test suite. This means a release can be approved and tagged even if some tests are failing.

Description

run-all-tests workflow for PR branches only (formerly build-test workflow): splits jobs into two groups with a hold-gated approval step.

Reduced Test Suite (runs automatically): lint, check-api-changes, validate-package-swift, run-test-ios-26, pod-lib-lint, run-revenuecat-ui-ios-26, emerge_purchases_ui_snapshot_tests, emerge_binary_size_analysis, build-tv-watch-and-macos, build-visionos
Full Test Suite (requires approving a hold job): all remaining jobs, unlocked by approving approve-full-tests.
all-tasks-passed: summary gate requiring all jobs to pass — set as a required GitHub check to block merges.
Workflow now excludes main and release/* branches to avoid redundant runs.

release-or-main workflow (renamed from all-tests): runs the full test suite on main, release/*, and manual triggers.

Adds all-tasks-passed summary gate requiring all jobs.
Absorbs release-checks, hold, and tag-release-branch from the removed create-tag workflow, so the release hold job approve-release requires both release-checks and all-tasks-passed.

Branch type	Behavior
PR branches	Reduced Test Suite runs automatically. Approve `approve-full-tests` to unlock Full Test Suite. Merge blocked until `all-tasks-passed`.
Release branches	All tests run in parallel (no hold). Release hold job `approve-release` requires both `release-checks` and `all-tasks-passed`.
main	All tests run in parallel. No release jobs.

Note

Triggering the full test suite via @RCGitBot please test is not needed anymore for PRs into main, since build-test already executes and requires the full suite (gated behind approve-full-tests). This trigger can still be useful for PRs that have a base branch different to main. In addition, the run-manual-tests CI parameter can still be useful for WIP branches that don't have an associated PR.

Move release-checks, hold, and tag-release-branch into the ci workflow (formerly all-tests) so the release hold requires both release-checks and all-tests-passed. Remove standalone create-tag workflow.

The "ci" workflow already includes everything

…s` is triggered

…-comments` is triggered" This reverts commit f6a32b2.

claude · 2026-02-10T12:10:21Z

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

tonidero

Looking great! mostly some naming and small thing comments 🙌

tonidero · 2026-02-11T10:19:02Z

.circleci/config.yml

+    steps:
+      - run:
+          name: Full suite gate passed
+          command: echo "Tier 1 passed and full tests approved - unlocking Tier 2"


I think the Tier 1 and Tier 2 comment can be confusing down the line once we forget or for new people. Maybe it should be something a bit more descriptive like Reduced Test Suite and Full Test Suite?

This applies to all mentions of these in this PR.

Thanks for the suggestion! I like it!

tonidero · 2026-02-11T10:22:31Z

.circleci/config.yml

-            - release-checks
-      - tag-release-branch:
+            - approve-full-tests
+            - lint


Hmm so seems we need to wait for the "reduced test suite" to finish before continuing with the full suite by having these here if I understand correctly?

That's correct! I made it so that we can approve the "approve-full-tests" immediately, but yes, the full test suite will wait for the reduced test suit to complete before starting running.
WDYT? Would you rather have it run in parallel?

Hmm I feel if you accept the hold job before it finishes the others, it makes sense to run in parallel. That’s my 2 cents though, NABD :)

Right. Tbh, I also had doubts about this.

it makes sense to run in parallel

That's actually how it still works with @RCGitBot please test: everything runs in parallel. The advantage of the hold job would be that it doesn't re-run the whole CI workflow, but just "unlocks" the full test suite.

So I'll remove the requirement of the other jobs for the full suite to start running. We can always tweak it in the future. Thanks for the suggestion!

.circleci/config.yml

tonidero · 2026-02-11T10:24:51Z

.circleci/config.yml

+      # Summary gate: blocks merge until all Tier 2 jobs pass
+      # Add "ci/circleci: all-tests-passed" as a required check in GitHub
+      # =============================================================
+      - all-tests-passed:


Maybe we should rename to all-tasks-finished instead? So it's something we can reuse for the release workflow as well?

tonidero · 2026-02-11T10:32:20Z

.circleci/config.yml

  #   - Name: action
  #   - Value: run-manual-tests
-  all-tests:
+  ci:


Hmm I'm not fully in love with this name for this workflow... Should it be release_or_main?

Right. I was torn on this one, as it's a workflow serving two purposes... it's true that it only runs on release branches or main. Honestly, I don't have a strong opinion and I do think release-or-main is clearer than just ci. however, this is the workflow that will run when we trigger the pipeline with the run-manual-tests parameter from CircleCI or with @RCGitBot please test.

Running tests manually won't be useful anymore for PRs, as now we'll have the hold job. However, there are some scenarios where we may want to run the release-or-main workflow for main (e.g. sometimes it does not get triggered correctly after merging a PR, so it needs to be run manually).

Still, having it be called release-or-main is clearer I think 👍

tonidero · 2026-02-11T10:32:48Z

.circleci/config.yml

+      # =============================================================
+      # Summary gate: all tests passed
+      # =============================================================
+      - all-tests-passed:


I think this would allow a release PR to be merged without approving the hold job... Maybe this should run only after the tag_current_branch job has run successfully?

Hmmm that's a good catch. But then, AFAIK, I don't think we can achieve this.

If I'm not wrong, GitHub status checks cannot be made depend on the source branch. I.e. they are defined for all PRs with main as the base branch. That means the check we decide to have must apply to all PRs, all-tasks-finished in this case.

Now, on CI config.yml, this would mean that all-tasks-finished should be different for release branches. I.e. we would need all-tasks-finished to require tag-release-branch. But that would not work for non-release PRs into main, where tag-release-branch is never run.

Am I missing something perhaps? I can try to think on workarounds for this though

I was confused, as all-tasks-passed (formerly, briefly known as all-tasks-finished) can actually have different requires in release-or-main vs run-all-tests.

So I implemented your proposal in fcb9287.

It makes total sense and it's way better to block merging the Release PR until after tag-release-branch runs. Great great suggestions! Thanks!

After some internal discussion, I've reverted it back to what we had before.
The reasoning is sometimes we need to push changes to the release branch after the release happens (main example of this: merging main into the release branch).

This way, we can still merge release PRs into main even after new commits pushed to it.

In any case, with this PR + #6243 the whole release process should improve, as we should not manually merge release PRs anymore.

We can always iterate

…branch`

…release-branch`" This reverts commit fcb9287.

Co-authored-by: Cursor <[email protected]>

ajpallares · 2026-02-12T15:36:48Z

@RevenueCat/coresdk I think this is now ready to be reviewed. I believe I addressed all comments from @tonidero's great review.

ajpallares added the pr:other label Feb 10, 2026

ajpallares force-pushed the pallares/change-ci-structure-for-PRs branch from 3b63721 to d57584b Compare February 10, 2026 10:25

Gate full CI suite behind approval job on PRs

6fbfe51

ajpallares force-pushed the pallares/change-ci-structure-for-PRs branch from d57584b to 6fbfe51 Compare February 10, 2026 10:26

ajpallares added 4 commits February 10, 2026 11:50

Gate release tagging behind all-tests-passed

21bbbeb

Move release-checks, hold, and tag-release-branch into the ci workflow (formerly all-tests) so the release hold requires both release-checks and all-tests-passed. Remove standalone create-tag workflow.

Exclude build-test workflow from main and release branches

de40c4c

The "ci" workflow already includes everything

Renamed "hold" job to "approve-release"

1401ef4

Merge branch 'main' into pallares/change-ci-structure-for-PRs

4d78abd

ajpallares force-pushed the pallares/change-ci-structure-for-PRs branch from 2758b9b to 4d78abd Compare February 10, 2026 11:20

ajpallares changed the title ~~Gate full CI suite behind approval hold job to prevent broken merges~~ Restructure CI with tiered PR checks and release gating Feb 10, 2026

ajpallares added 2 commits February 10, 2026 12:42

Skip build-test when run-manual-tests or `run-from-github-comment…

f6a32b2

…s` is triggered

Revert "Skip build-test when run-manual-tests or `run-from-github…

894f27e

…-comments` is triggered" This reverts commit f6a32b2.

ajpallares marked this pull request as ready for review February 10, 2026 12:04

ajpallares requested a review from a team as a code owner February 10, 2026 12:04

ajpallares added 2 commits February 10, 2026 14:09

rename build-test workflow to run-all-tests

6939ea7

Add missing jobs to ci workflow (for main and for release branches)

28cde3a

tonidero reviewed Feb 11, 2026

View reviewed changes

ajpallares and others added 7 commits February 12, 2026 09:08

PR comments

6858b85

Merge branch 'main' into pallares/change-ci-structure-for-PRs

e80128d

Rename all-tasks-finished to all-tasks-passed

e65a633

Have release branches run all-tasks-passed only after `tag-release-…

fcb9287

…branch`

Revert "Have release branches run all-tasks-passed only after `tag-…

faee21d

…release-branch`" This reverts commit fcb9287.

Merge branch 'main' into pallares/change-ci-structure-for-PRs

ecb1011

Require Reduced Test Suite jobs in all-tasks-passed summary gate

6e17223

Co-authored-by: Cursor <[email protected]>

Merge branch 'main' into pallares/change-ci-structure-for-PRs

b93e326

Restructure CI with tiered PR checks and release gating #6241

Are you sure you want to change the base?

Restructure CI with tiered PR checks and release gating #6241

Conversation

ajpallares commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Description

Note

Uh oh!

claude bot commented Feb 10, 2026

Code review

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ajpallares commented Feb 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ajpallares commented Feb 10, 2026 •

edited

Loading