Skip to content

Explicit nullable type must be used instead (PHP8.4) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Explicit nullable type must be used instead (PHP8.4) #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Block/Product/RatingSnippet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ public function __construct(
\Magento\Catalog\Api\CategoryRepositoryInterface $categoryRepository,
\Magento\Framework\Url\Helper\Data $urlHelper,
array $data = [],
\Magento\Customer\Model\Session $customerSession = null,
\Magento\Catalog\Model\CategoryFactory $categoryFactory = null,
ReviewsConfig $reviewsConfigHelper = null,
StoreManagerInterface $storeManager = null
?\Magento\Customer\Model\Session $customerSession = null,
?\Magento\Catalog\Model\CategoryFactory $categoryFactory = null,
?ReviewsConfig $reviewsConfigHelper = null,
?StoreManagerInterface $storeManager = null
) {
$this->_customerSession = $customerSession;
$this->categoryFactory = $categoryFactory;
Expand Down
2 changes: 1 addition & 1 deletion Block/Richsnippet.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function getRichSnippetSource()
return '<script src="' . $url . '"></script>';
}

public function getRichSnippet($sku = null, $product = null)
public function getRichSnippet(?$sku = null, ?$product = null)
{
if (isset($sku) && is_array($sku)) {
$sku = implode(';', $sku);
Expand Down
4 changes: 2 additions & 2 deletions Model/Api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public function __construct(
$this->store = $storeManagerInterface->getStore();
}

public function apiPost($url, $data, $magento_store_id = null)
public function apiPost($url, $data, ?$magento_store_id = null)
{
if ($magento_store_id == null) {
$magento_store_id = $this->store->getId();
Expand All @@ -51,7 +51,7 @@ public function apiPost($url, $data, $magento_store_id = null)
return $response;
}

protected function getApiDomain($magento_store_id = null)
protected function getApiDomain(?$magento_store_id = null)
{
return $this->configHelper->getRegion($magento_store_id) == 'US' ? 'api.reviews.io' : 'api.reviews.co.uk';
}
Expand Down