refactor: removing pygame as audio player, using GStreamer/GTKFileStream #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR, Hadi. I would love to see PyGame gone as much as you do, but there is an issue. During testing, I found that the drum machine creates new playback streams for each sound instead of reusing one stream. This should be addressed to avoid cluttering the audio interface and potential performance issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since using pygame for audio playback significantly increased the program size and made development somewhat annoying, I completely removed this package and switched to GStreamer and GtkMediaFile.
The only current issue is the multiple audio channels being created; they need to be mixed.
Type of Change