Enhancement: Add pre-commit #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, thanks for the PR and sorry it took so long. |
Revisto
requested changes
Dec 22, 2025
| args: [--count, '--select=E9,F63,F7,F82', --show-source, --statistics, --builtins="_"] | ||
| - id: flake8 | ||
| name: flake8-style | ||
| args: [--count, --max-complexity=10, --max-line-length=88, --statistics] |
Owner
There was a problem hiding this comment.
The indentation in .pre-commit-config.yaml is inconsistent, it's using 3-4 spaces instead of the standard 2-space YAML indentation. Should be cleaned up.
Something like:
repos:
- repo: https://github.com/PyCQA/flake8
rev: 7.3.0
hooks:
- id: flake8
name: flake8-syntax
args: [--count, '--select=E9,F63,F7,F82', --show-source, --statistics, --builtins="_"]
- id: flake8
name: flake8-style
args: [--count, --max-complexity=10, --max-line-length=88, --statistics]
Revisto
requested changes
Dec 22, 2025
Owner
Revisto
left a comment
Revisto
left a comment
There was a problem hiding this comment.
It would be nice to update the CONTRIBUTING.md and include instructions to install pre-commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces pre-commit hooks to ensure lint checks are run locally before pushing the changes.
Type of Change
Additional Notes
Reorganizes how the requirements are grouped together for better maintainability.
closes #87