fix: sibling detection false positive when prefix#152
Merged
Revxrsal merged 3 commits intoRevxrsal:v4from Feb 6, 2026
Merged
Conversation
SkytAsul
added a commit
to SkytAsul/BeautyQuests
that referenced
this pull request
Feb 1, 2026
Closes #381. Requires Revxrsal/Lamp#152 to be merged for this to function properly.
e.g. `bq help` has siblings `bq test` AND `bquests test`, since `bquests` starts with `bq` (but it's a coincidence) This also fixes Revxrsal#114.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples of fixed siblings:
bq helphas siblingsbq testANDbquests test, sincebquestsstarts withbq(but it's a coincidence). This has been fixed by changing the siblingPath from a simple String to an array of Strings.bq helphas siblingsomeCommand [something]since initially the siblingPath ofsomeCommand [something]was the empty string. This has been fixed by setting the siblingPath to the first node literal when it only contains one (so, when the command is a "top-level" command).This closes #114.