Enhance Money.Scan to support JSON input

[atakanozceviz]

Summary by Sourcery

Enhance Money.Scan to accept and unmarshal JSON payloads, streamline type assertions and error messages, and extend tests to cover the new JSON behavior.

New Features:

• Support JSON input for Money.Scan from string and []byte sources.

Enhancements:

• Refactor type switches and simplify error formatting in Money.Scan and Currency.Scan.

Tests:

• Add TestMoney_Scan cases for JSON object and empty JSON inputs.
• Simplify test assertion logic and error reporting in TestMoney_Scan.

[sourcery-ai]

Reviewer's Guide

This PR extends the Money.Scan method to parse JSON representations of Money (both string and []byte), refactors type-switch handling for cleaner assertions and error messages, and augments unit tests with JSON scenarios and improved comparison logic.

Sequence diagram for Money.Scan with JSON input

sequenceDiagram
    participant DB as Database
    participant Money as Money
    participant JSON as UnmarshalJSON
    DB->>Money: Scan(src interface{})
    alt src is string and starts with '{'
        Money->>JSON: UnmarshalJSON(m, []byte(src))
    else src is []byte
        Money->>JSON: UnmarshalJSON(m, src)
    else src is string (legacy)
        Money->>Money: Parse amount and currency
    else
        Money->>Money: Return error
    end

Loading

File-Level Changes

Change	Details	Files
Add JSON parsing support to Money.Scan	Detect JSON payloads in string inputs and route to UnmarshalJSON Handle []byte inputs by forwarding to UnmarshalJSON	db.go
Refactor type-switch assertions and error messages	Use “switch src := src.(type)” to eliminate repeated casts Update error formatting to include the direct src variable instead of a cast	db.go
Enhance unit tests for JSON scenarios and fix comparison logic	Add tests for JSON string and []byte Money inputs and empty JSON Improve test assertion by directly comparing pointer values and reporting errors via t.Error	db_test.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @atakanozceviz - I've reviewed your changes - here's some feedback:

• Consider trimming leading whitespace from src before checking for '{' to avoid misclassifying JSON strings with leading spaces.
• Wrap or annotate errors returned from UnmarshalJSON so that JSON scanning failures include more context about the input causing the issue.
• Update the default Scan error messages to reflect JSON support (instead of always mentioning the DBMoneyValueSeparator) to avoid confusing errors for JSON inputs.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Consider trimming leading whitespace from src before checking for '{' to avoid misclassifying JSON strings with leading spaces.
- Wrap or annotate errors returned from UnmarshalJSON so that JSON scanning failures include more context about the input causing the issue.
- Update the default Scan error messages to reflect JSON support (instead of always mentioning the DBMoneyValueSeparator) to avoid confusing errors for JSON inputs.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}