Add sqs and dynamodb prefixes to connection urls#721
Open
Blquinn wants to merge 1 commit intoRichardKnop:masterfrom
Open
Add sqs and dynamodb prefixes to connection urls#721Blquinn wants to merge 1 commit intoRichardKnop:masterfrom
Blquinn wants to merge 1 commit intoRichardKnop:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After playing around with machinery on my local machine, I saw that the way that you can connect to non https aws services is with DISABLE_STRICT_SQS_CHECK. I think it is safer and more explicit to just add a prefix to the http/https urls.
Example sqs url: sqs+http://localhost:4566/000000000000
Example dynamodb url: dynamodb+http://localhost:6379/1