Conversation
해당 서비스는 도메인에 위치하는 것이 맞는 듯함. 인터페이스 선언이 domain에 있고, 서비스는 인터페이스만 있으면 됨.
백그라운드 상태에서 포그라운드 상태로 넘어올 경우 데이터를 새로고침하여 보여주도록 함. Pull To Refresh 시 인디케이터를 짧게 보여줌. -> 성능 빠른 것처럼 보이게.
최신 API를 적극 활용할 수 있도록 target APi를 최신버전인 35로 설정
Closed
2 tasks
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR
작업 내용
참고 사항
새로고침 로직이 많이 들어감에 따라,
새로운 알림이 들어왔다는 UI를 보여줄 필요가 있는 지 확실치 않아 제외했습니다.
이후 필요하다는 피드백이 있을 경우 추가하겠습니다.
✏ Git Close
#26