Merged
Conversation
기본적으로 한국어, 영어를 지원해주기 위해 두개의 xml 파일을 생성함.
앱에서 활용되는 모든 텍스트가 미리 정의된 문자열 리소스를 활용하도록 구현함. 아직 content description 부분은 미구현 상태
상대 시간 표시에 영어도 포함함.
Closed
2 tasks
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR
작업 내용
참고 사항
원래 앱에서 언어 설정을 바꿀 수 있도록 하려 했으나,
불필요하게 복잡하고 쓸 일이 없을 듯해서 추가하지 않았습니다.
지원 언어가 한국어 아니면 영어인데, 한국인이 굳이 영어로 앱을 쓸 일이 없다고 봤기 때문입니다.
어색한 영어 표현은 차차 수정해보겠습니다.
✏ Git Close
#47