Skip to content

Commit d2e941b

Browse files
Kamal Sai DevarapalliKamal Sai Devarapalli
authored andcommitted
fix: resolve line length issues in taskprocessing service views
- Fix long import statements by splitting across lines - Convert f-string logging to lazy % formatting for better performance - Wrap long expressions in parentheses for proper line breaking - Fix lines exceeding 79-character limit in all taskprocessing views - Improve code readability while maintaining PEP 8 compliance
1 parent f66c83a commit d2e941b

File tree

4 files changed

+43
-21
lines changed

4 files changed

+43
-21
lines changed

services/taskprocessing/app/views/cancel_task.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@
1414
from common.pyportal_common.error_handlers.invalid_request_handler import (
1515
send_invalid_request_error_to_client,
1616
)
17-
from common.pyportal_common.error_handlers.internal_server_error_handler import (
18-
send_internal_server_error_to_client,
19-
)
17+
from common.pyportal_common.error_handlers.\
18+
internal_server_error_handler import (
19+
send_internal_server_error_to_client,
20+
)
2021

2122

2223
def cancel_task(task_id):

services/taskprocessing/app/views/create_task.py

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@
1515
from common.pyportal_common.error_handlers.invalid_request_handler import (
1616
send_invalid_request_error_to_client,
1717
)
18-
from common.pyportal_common.error_handlers.internal_server_error_handler import (
19-
send_internal_server_error_to_client,
20-
)
18+
from common.pyportal_common.error_handlers.\
19+
internal_server_error_handler import (
20+
send_internal_server_error_to_client,
21+
)
2122
from common.pyportal_common.utils import mask_request_headers
2223

2324

@@ -74,11 +75,15 @@ def create_task():
7475
if task_type not in valid_task_types:
7576
return send_invalid_request_error_to_client(
7677
app_logger_name=taskprocessing_logger,
77-
message_data=f"Invalid task type. Must be one of: {', '.join(valid_task_types)}",
78+
message_data=(
79+
f"Invalid task type. Must be one of: "
80+
f"{', '.join(valid_task_types)}"
81+
),
7882
)
7983

8084
taskprocessing_logger.info(
81-
f"Creating task - Type: {task_type}, User: {user_id}, Priority: {priority}"
85+
"Creating task - Type: %s, User: %s, Priority: %s",
86+
task_type, user_id, priority
8287
)
8388

8489
session = app_manager_db_obj.get_session_from_session_maker()
@@ -89,7 +94,10 @@ def create_task():
8994
)
9095

9196
try:
92-
task_reference = f"TASK{datetime.now().strftime('%Y%m%d')}{uuid.uuid4().hex[:8].upper()}"
97+
task_reference = (
98+
f"TASK{datetime.now().strftime('%Y%m%d')}"
99+
f"{uuid.uuid4().hex[:8].upper()}"
100+
)
93101

94102
task = TaskModel(
95103
TaskType=task_type,
@@ -109,7 +117,8 @@ def create_task():
109117
session.commit()
110118

111119
taskprocessing_logger.info(
112-
f"Task created successfully: {task_reference} (ID: {task_id})"
120+
"Task created successfully: %s (ID: %s)",
121+
task_reference, task_id
113122
)
114123

115124
if taskprocessing_kafka_producer:
@@ -127,7 +136,8 @@ def create_task():
127136
task_event
128137
)
129138
taskprocessing_logger.info(
130-
f"Published task_created event to Kafka: {task_reference}"
139+
"Published task_created event to Kafka: %s",
140+
task_reference
131141
)
132142
# pylint: disable=broad-except
133143
except Exception as kafka_ex:

services/taskprocessing/app/views/get_task.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@
99
from common.pyportal_common.error_handlers.not_found_error_handler import (
1010
send_notfound_request_error_to_client,
1111
)
12-
from common.pyportal_common.error_handlers.internal_server_error_handler import (
13-
send_internal_server_error_to_client,
14-
)
12+
from common.pyportal_common.error_handlers.\
13+
internal_server_error_handler import (
14+
send_internal_server_error_to_client,
15+
)
1516

1617

1718
def get_task(task_id):
@@ -51,10 +52,17 @@ def get_task(task_id):
5152
"parameters": task.Parameters,
5253
"result": task.Result,
5354
"errorMessage": task.ErrorMessage,
54-
"processingTime": float(task.ProcessingTime) if task.ProcessingTime else None,
55+
"processingTime": (
56+
float(task.ProcessingTime)
57+
if task.ProcessingTime else None
58+
),
5559
"createdAt": str(task.CreatedAt),
56-
"startedAt": str(task.StartedAt) if task.StartedAt else None,
57-
"completedAt": str(task.CompletedAt) if task.CompletedAt else None,
60+
"startedAt": (
61+
str(task.StartedAt) if task.StartedAt else None
62+
),
63+
"completedAt": (
64+
str(task.CompletedAt) if task.CompletedAt else None
65+
),
5866
"updatedAt": str(task.UpdatedAt),
5967
}
6068
}

services/taskprocessing/app/views/list_tasks.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
app_manager_db_obj,
77
)
88
from app.models.task_model import TaskModel
9-
from common.pyportal_common.error_handlers.internal_server_error_handler import (
10-
send_internal_server_error_to_client,
11-
)
9+
from common.pyportal_common.error_handlers.\
10+
internal_server_error_handler import (
11+
send_internal_server_error_to_client,
12+
)
1213

1314

1415
def list_tasks():
@@ -60,7 +61,9 @@ def list_tasks():
6061
"priority": task.Priority,
6162
"progress": task.Progress,
6263
"createdAt": str(task.CreatedAt),
63-
"completedAt": str(task.CompletedAt) if task.CompletedAt else None,
64+
"completedAt": (
65+
str(task.CompletedAt) if task.CompletedAt else None
66+
),
6467
})
6568

6669
response_data = {

0 commit comments

Comments
 (0)