Skip to content

Build fixes#86

Draft
ohlidalp wants to merge 2 commits intoRigsOfRods:masterfrom
ohlidalp:build_fixes_all
Draft

Build fixes#86
ohlidalp wants to merge 2 commits intoRigsOfRods:masterfrom
ohlidalp:build_fixes_all

Conversation

@ohlidalp
Copy link
Copy Markdown
Member

@ohlidalp ohlidalp commented Nov 4, 2024

Collection of build fixes:

This PR attempts to fix the GitHub build failure, I can't reproduce it on my PC.

those are cmake keywords that are treated literally due to "" around {FREETYPE_LIBRARIES}

related: OGRECave/ogre#843
This fixes build error `Error C2039 'binary_function': is not a member of 'std' ` in FreeImage/OpenEXR under latest Visual Studio 2022
See https://learn.microsoft.com/en-us/answers/questions/1348183/std-binary-function-is-missing-in-msvc-14-37-32822

I tried upgrading FreeImage to latest but it has the same issue (July 31st, 2018: FreeImage 3.18.0 released).
Note ours is pretty old (March 17th, 2012: FreeImage 3.15.3 released).

I ended up just deleting the offending code because it turned out to be deadcode (a `std::map` compare func has nothing to do with `binary_function`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant