Skip to content

bug fix for issue #283. Ensure updateCard title has a tag #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bwaite-esr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug fix for issue #283. Ensure updateCard title has a tag #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions R/cards.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,18 +482,21 @@ updatebs4Card <- function(id, action = c("remove", "toggle", "toggleMaximize", "
action <- match.arg(action)
# for update, we take a list of options
if (action == "update") {
# handle case whare options are shiny tag or a list of tags ...
options <- lapply(options, function(o) {
if (inherits(o, "shiny.tag") || inherits(o, "shiny.tag.list")) {
o <- as.character(o)
return(o)
# handle case where options are shiny tag or a list of tags ...
options <- setNames(lapply(seq_along(options), function(o,option_list = options) {
option_value <- option_list[[o]]
if (inherits(option_value, "shiny.tag") || inherits(option_value, "shiny.tag.list")) {
option_value <- as.character(option_value)
return(option_value)
} else if (names(option_list)[[o]] == "title") {
option_value <- shiny::tags$h3(option_value)
}
if (inherits(o, "list")) {
o <- unlist(
if (inherits(option_value, "list")) {
option_value <- unlist(
dropNulls(
lapply(o, function(e) {
lapply(option_value, function(e) {
if (inherits(e, "shiny.tag.list") ||
inherits(e, "shiny.tag")) {
inherits(e, "shiny.tag")) {
as.character(e)
} else {
e
Expand All @@ -502,8 +505,8 @@ updatebs4Card <- function(id, action = c("remove", "toggle", "toggleMaximize", "
)
)
}
o
})
option_value
}),names(options))
message <- dropNulls(c(action = action, options = list(options)))
session$sendInputMessage(id, message)
} else {
Expand Down