support tabsetPanel vertical tab width#395
Open
eblondel wants to merge 1 commit intoRinteRface:masterfrom
Open
support tabsetPanel vertical tab width#395eblondel wants to merge 1 commit intoRinteRface:masterfrom
eblondel wants to merge 1 commit intoRinteRface:masterfrom
Conversation
Member
|
Thanks for the PR. I'll have a look as soon as possible this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @DivadNojnarg first of all many thanks for bs4Dash, really great!
Here's a small PR to give more flexibility in
tabsetPanel, adding a vertical tabwidtharg. Indeed, when using theverticalmode, depending on thetabPaneltitle text length, the default width of 2, which is hardcoded now, becomes a constraint. As a result text of the tab content is overlaying the title. To fix this, a simple way is to have control on the tab width. In my case I had some of the tabPanel titles for which a tab width of 3 is more appropriate.This
widtharg can be set to 2 by default to keep backward compatibility, let me know if it is ok for you.Best
Emmanuel