Staging #159
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,36 @@ | ||
| import "./styles.css"; | ||
|
|
||
| const ActionButton = ({ | ||
| backgroundColor, | ||
| color, | ||
| text, | ||
| width, | ||
| onClick, | ||
| margin, | ||
| className = "", | ||
|
There was a problem hiding this comment. suggestion (bug_risk): Defaulting className to an empty string may cause confusion. Default className to undefined and only append it when truthy to avoid empty class attributes and expose missing class names. |
||
| }) => { | ||
| const useInlineStyles = !className; | ||
|
There was a problem hiding this comment. issue: The logic for useInlineStyles may not work as intended if className is an empty string. With className defaulting to '', !className is always true, so inline styles always apply. Check for a non-empty string instead. |
||
|
|
||
| const buttonStyle = useInlineStyles | ||
| ? { | ||
| backgroundColor: backgroundColor || "#000000", | ||
| color: color || "#FFFFFF", | ||
| borderRadius: "6px", | ||
| padding: "10px 20px", | ||
| fontWeight: 500, | ||
| fontSize: "20px", | ||
| border: "none", | ||
| cursor: "pointer", | ||
| width: width || "auto", | ||
| margin: margin || "0px", | ||
| } | ||
| : { width, margin }; | ||
|
|
||
| return ( | ||
| <button className={`${className}`} style={buttonStyle} onClick={onClick}> | ||
| {text} | ||
| </button> | ||
| ); | ||
| }; | ||
|
|
||
| export default ActionButton; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: Consider standardizing diagram image filename.
The '2.0' suffix isn’t needed unless you’re tracking versions for display. Rename to
Component Diagram.pngto match other filenames likeERD.pngandFlow Diagram.png.