Merged
Conversation
…nd modified ReadMe file
provider_profile_and_user_dev: Added ProviderProfile Component Code a…
Reviewer's GuideThis PR revamps the provider profile feature by replacing static markup with a dynamic, state-driven form and a dedicated service for updates, introduces a new ProfileMenu for user actions, cleans up redundant code, fixes a prediction service endpoint, and reorganizes documentation sections and diagrams. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Riyad-Murad - I've reviewed your changes - here's some feedback:
- Consider removing the large block of commented-out code in InputField.jsx to keep the component clean and maintainable.
- The fixed 300px margin-left in your profile wrapper CSS could break across different layouts—consider using a more responsive approach (e.g., flex/grid or theme-based spacing).
- The profile form currently allows submitting without any validation or loading feedback; adding basic client-side validation and a disabled/loading state on submit would improve the UX.
Here's what I looked at during the review
- 🟡 General issues: 4 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| <div className="provider-profile-card"> | ||
| <h2 className="provider-profile-subtitle">Edit Provider Profile</h2> | ||
| <form className="provider-profile-form"> |
There was a problem hiding this comment.
suggestion (bug_risk): Attach handleSubmit to form onSubmit instead of button onClick
Also update the button to type="submit" so pressing Enter submits the form and you don’t mix click and submit events.
Suggested implementation:
<form className="provider-profile-form" onSubmit={handleSubmit}> <button
type="submit"
className="provider-profile-submit"
>| import ActionButton from "../../../Components/CommonComponents/ActionButton/ActionButton"; | ||
|
|
||
| const ProviderProfile = () => { | ||
| const [formData, setFormData] = useState({ |
There was a problem hiding this comment.
suggestion: Profile form fields initialized as empty
Fetch existing profile data on mount to pre-fill the form and avoid forcing users to re-enter unchanged values.
| name: "", | ||
| email: "", | ||
| password: "", | ||
| phone_number: "", |
There was a problem hiding this comment.
suggestion: Use consistent camelCase naming for JavaScript fields
phone_number is snake_case; change it to phoneNumber and adjust the API mapping as needed.
Comment on lines
+26
to
+27
| toast.success("Profile updated successfully."); | ||
| setTimeout(() => navigate("/provider/dashboard"), 1000); |
There was a problem hiding this comment.
suggestion: Avoid setTimeout for post-update navigation
A fixed timeout can lead to inconsistent UX—navigate in the toast’s onClose callback or immediately after the success response.
Suggested change
| toast.success("Profile updated successfully."); | |
| setTimeout(() => navigate("/provider/dashboard"), 1000); | |
| toast.success("Profile updated successfully.", { | |
| onClose: () => navigate("/provider/dashboard"), | |
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enable providers to edit their profiles via a revamped UI that validates inputs, filters empty fields, and shows success or error toasts before redirecting. Introduce a dropdown-based ProfileMenu in the sidebar and update styles. Also refine README diagrams and add API reference.
New Features:
Bug Fixes:
Enhancements:
Documentation: