Merged
Conversation
admin_pages_dev: Modified docker-compose configurattion
Reviewer's GuideThis PR bounds container resource usage by adding memory and CPU limits, introduces a low-memory MySQL config, updates CI/CD workflows to deploy it, and enhances the Docker entrypoint script with cache-clearing and caching steps before migrations. Flow Diagram: Updated amp-laravel Startup Script (dockerShell.sh)graph TD
Start["Previous steps (e.g., composer install)"] --> ConfigClear["php artisan config:clear"]
ConfigClear --> NewCacheClear["php artisan cache:clear (New)"]
NewCacheClear --> NewRouteClear["php artisan route:clear (New)"]
NewRouteClear --> NewViewClear["php artisan view:clear (New)"]
NewViewClear --> ConfigCache["php artisan config:cache"]
ConfigCache --> NewRouteCache["php artisan route:cache (New)"]
NewRouteCache --> NewViewCache["php artisan view:cache (New)"]
NewViewCache --> Migrate["php artisan migrate --seed --force"]
Migrate --> Apache["apache2-foreground"]
Apache --> End["Service Running"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @Riyad-Murad - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| source: "amp-client/dist" | ||
| target: "/home/${{ secrets.EC2_USER }}/" | ||
|
|
||
| - name: Copy Database Low Memory cofiguration file to EC2 |
There was a problem hiding this comment.
nitpick (typo): Fix typo in step name
Fix typo: change 'cofiguration' to 'configuration'.
Suggested change
| - name: Copy Database Low Memory cofiguration file to EC2 | |
| - name: Copy Database Low Memory configuration file to EC2 |
| source: "docker-compose.yaml" | ||
| target: "/home/${{ secrets.EC2_USER }}/" | ||
|
|
||
| - name: Copy Database Low Memory cofiguration file to EC2 |
There was a problem hiding this comment.
nitpick (typo): Fix typo in step name
Also correct 'cofiguration' to 'configuration' here.
Suggested change
| - name: Copy Database Low Memory cofiguration file to EC2 | |
| - name: Copy Database Low Memory configuration file to EC2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Apply resource constraints to Docker services, optimize Laravel container startup with cache operations, and update CI workflows to deploy a custom low-memory MySQL configuration.
Enhancements:
CI:
Chores: