Merged
Conversation
GilMM27
previously requested changes
Jun 23, 2025
src/app/(pages)/admin/page.tsx
Outdated
| @@ -0,0 +1,16 @@ | |||
| import Title from "~/app/_components/title"; | |||
| import AdminViewBlock from "~/app/_components/admin/adminViewBlock"; | |||
| import { api } from "~/trpc/server"; | |||
Contributor
There was a problem hiding this comment.
prefer use of trpc/react for react components
src/app/(pages)/admin/page.tsx
Outdated
| return ( | ||
| <div className="flex flex-col gap-12"> | ||
| <Title label="Problem Setup"/> | ||
| { weeks.map((w) => <AdminViewBlock key={w.id} problems={problems} week={w} /> ) } |
Contributor
There was a problem hiding this comment.
it seems like the tables columns aren't aligned
| <th> Problem </th> | ||
| <th> Difficulty </th> | ||
| <th> Solved by </th> | ||
| <th> </th> |
Contributor
There was a problem hiding this comment.
what is it supposed to be? I don't see it
src/app/_components/nav/navbar.tsx
Outdated
| <NavElement href="/weekly-problems" label="Weekly Problems" /> | ||
| <NavElement href="/leaderboard" label="Leaderboard" /> | ||
| <NavElement href="/resources" label="Resources" /> | ||
| <NavElement href="/admin" label="Manage" /> |
Contributor
There was a problem hiding this comment.
can we only show this option if the user is an admin?
Rodrogamby
commented
Jun 26, 2025
Rodrogamby
commented
Jun 26, 2025
Contributor
Author
|
|
Contributor
Author
|
|
Rodrogamby
dismissed
GilMM27’s stale review
Changes requested by Gil have been applied, but he's on vacation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15