Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the cost of having a larger
roaring.hfile, this PR significantly improves the performance ofroaring_bitmap_contains.Before
After
By allowing more inlining of
container_iterator_nextandcontainer_iterator_prev, it also helps the performance of other functions. I get that IterateAll64 is faster now.Before
After
It also seems to help the
RandomAccess64Cppbenchmark, but not thatRandomAccess64results. Soroaring64_bitmap_containsis NOT improved much (if at all) by this PR.Before:
After:
Fixes: #755