Run CI against illumos and make the tests pass. #771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want to use the `restrict` keyword in C, not in C++. Under linux, darwin, etc., we can check for `__STDC_VERSION__` to verify that we're compiling C and not C++. However, illumos defines `__STDC_VERSION__` whether we're compiling C *or* C++. To ensure that we don't use the `restrict` keyword in C++ on illumos, this patch adds a check on `__cplusplus` as well, and skips `restrict` if it's defined. This patch also adds a test workflow for illumos to avoid future regressions.
Member
|
Looks good. Let us run the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want to use the
restrictkeyword in C, not in C++. Under linux, darwin, etc., we can check for__STDC_VERSION__to verify that we're compiling C and not C++. However, illumos defines__STDC_VERSION__whether we're compiling C or C++. To ensure that we don't use therestrictkeyword in C++ on illumos, this patch adds a check on__cplusplusas well, and skipsrestrictif it's defined.This patch also adds a test workflow for illumos to avoid future regressions.
Before submitting this PR, run
tools/run-clangcldocker.shon your changes if you can. See the "Contributing" section in the README for details. It is acceptable to skip this formatting.