Skip to content

Switch Codable encoding scheme from a base64-encoded string wrapped in an array to just a single base64-encoded string #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemire merged 1 commit into from
Feb 20, 2025
Merged

Switch Codable encoding scheme from a base64-encoded string wrapped in an array to just a single base64-encoded string #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SwiftRoaring/RoaringBitmap.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ public final class RoaringBitmap: Sequence, Equatable, CustomStringConvertible,
/// Encodable conformance
///
public func encode(to encoder: Encoder) throws {
var container = encoder.unkeyedContainer()
var container = encoder.singleValueContainer()
let count = self.sizeInBytes()
var data = Data(count: count)

Expand All @@ -768,7 +768,7 @@ public final class RoaringBitmap: Sequence, Equatable, CustomStringConvertible,
/// Decodable conformance
///
public init(from decoder: Decoder) throws {
var container = try decoder.unkeyedContainer()
let container = try decoder.singleValueContainer()

let buffer = try container.decode(String.self)
let data = Data(base64Encoded: buffer)
Expand Down
2 changes: 1 addition & 1 deletion Tests/swiftRoaringTests/swiftRoaringTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ class swiftRoaringTests: XCTestCase {
let s = String(data: a, encoding: .utf8)!
print(s.count)
let b = try! dec.decode(RoaringBitmap.self, from: a)
let expected = "[\"AjowAAABAAAAAAAxABAAAAAAAAIABAAGAAgACgAMAA4AEAASABQAFgAYABoAHAAeACAAIgAkACYAKAAqACwALgAwADIANAA2ADgAOgA8AD4AQABCAEQARgBIAEoATABOAFAAUgBUAFYAWABaAFwAXgBgAGIA\"]"
let expected = "\"AjowAAABAAAAAAAxABAAAAAAAAIABAAGAAgACgAMAA4AEAASABQAFgAYABoAHAAeACAAIgAkACYAKAAqACwALgAwADIANAA2ADgAOgA8AD4AQABCAEQARgBIAEoATABOAFAAUgBUAFYAWABaAFwAXgBgAGIA\""

XCTAssert(s == expected)

Expand Down
Loading