fix: do not accidently remove zeros in vector sub#330
Merged
Kerollmops merged 1 commit intoRoaringBitmap:mainfrom Jul 10, 2025
Merged
fix: do not accidently remove zeros in vector sub#330Kerollmops merged 1 commit intoRoaringBitmap:mainfrom
Kerollmops merged 1 commit intoRoaringBitmap:mainfrom
Conversation
Previously, we filled a partial buffer with the integers to remove, but the rest of the buffer would be filled with zeros, which could mean we could end up removing a zero from the bitmap even if zero was not in the list of values to remove.
Kerollmops
approved these changes
Jul 10, 2025
Member
There was a problem hiding this comment.
Nice catch @Dr-Emann 👏
Merging it right now and will do a release soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we filled a partial buffer with the integers to remove, but the rest of the buffer would be filled with zeros, which could mean we could end up removing a zero from the bitmap even if zero was not in the list of values to remove.
Fixes #327