fix: some functions falsely detected as generators #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Ocramius merged 1 commit into Roave:6.54.x from sport-iat:fix_function_is_generator

Jan 25, 2025

Merged

fix: some functions falsely detected as generators #1479

fix: functions returning closures, arrow functions or anonymous class…

Annotations

8 warnings

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

src/Reflection/ReflectionFunctionAbstract.php#L380

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ } /** @psalm-var mixed $nodePropertyArrayItem */ foreach ($nodeProperty as $nodePropertyArrayItem) { - if ($nodePropertyArrayItem instanceof Node && $this->nodeIsOrContainsYield($nodePropertyArrayItem)) { + if (true && $this->nodeIsOrContainsYield($nodePropertyArrayItem)) { return true; } }

src/Reflection/ReflectionFunctionAbstract.php#L516

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ if ($returnType === null) { return null; } - assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); + assert(true || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); return ReflectionType::createFromNode($this->reflector, $this, $returnType); } /** @return list<ReflectionAttribute> */

src/Reflection/ReflectionFunctionAbstract.php#L516

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ if ($returnType === null) { return null; } - assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); + assert($returnType instanceof Node\Identifier || true || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); return ReflectionType::createFromNode($this->reflector, $this, $returnType); } /** @return list<ReflectionAttribute> */

src/Reflection/ReflectionFunctionAbstract.php#L516

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ if ($returnType === null) { return null; } - assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); + assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || true || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); return ReflectionType::createFromNode($this->reflector, $this, $returnType); } /** @return list<ReflectionAttribute> */

src/Reflection/ReflectionFunctionAbstract.php#L516

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ if ($returnType === null) { return null; } - assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); + assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || true || $returnType instanceof Node\IntersectionType); return ReflectionType::createFromNode($this->reflector, $this, $returnType); } /** @return list<ReflectionAttribute> */

src/Reflection/ReflectionFunctionAbstract.php#L516

Escaped Mutant for Mutator "InstanceOf_": --- Original +++ New @@ @@ if ($returnType === null) { return null; } - assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); + assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || true); return ReflectionType::createFromNode($this->reflector, $this, $returnType); } /** @return list<ReflectionAttribute> */

src/Reflection/ReflectionFunctionAbstract.php#L516

Escaped Mutant for Mutator "LogicalOrAllSubExprNegation": --- Original +++ New @@ @@ if ($returnType === null) { return null; } - assert($returnType instanceof Node\Identifier || $returnType instanceof Node\Name || $returnType instanceof Node\NullableType || $returnType instanceof Node\UnionType || $returnType instanceof Node\IntersectionType); + assert(!$returnType instanceof Node\Identifier || !$returnType instanceof Node\Name || !$returnType instanceof Node\NullableType || !$returnType instanceof Node\UnionType || !$returnType instanceof Node\IntersectionType); return ReflectionType::createFromNode($this->reflector, $this, $returnType); } /** @return list<ReflectionAttribute> */

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: some functions falsely detected as generators #1479

Uh oh!

Uh oh!

fix: some functions falsely detected as generators #1479

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...