Inline array_map(fn, $arr) and use foreach-loop instead #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that I'm skeptical about this: phpstan/phpstan-src#3926 (comment) |
|
I'm also not really looking forward to maintaining more loops: would rather endorse pushing the concern to php-src, at the cost of performance overhead here, for now. |
|
Nice! |
|
php 8.5.x is running ~10% faster thanks to recent fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a perf review togehter with nielsdos (php-src core develoepr) we identified
array_map, when used with a callback function to be a hotspot in PHPStan analysis, see https://phpc.social/@markusstaab/114301182551454759I've did some research and used some hack to record the call count of
array_mapwhen running PHPStan and isolate the following list of call sites from BetterReflection.the list contains 3 outstanding callers which dominate the call-counts. these occurences have been adjusted with this PR.