Skip to content

Faster getTraits() methods #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Faster getTraits() methods #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Reflection/Adapter/ReflectionClass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,14 +384,14 @@ public function getTraits(): array
{
$traits = $this->betterReflectionClass->getTraits();

/** @var list<trait-string> $traitNames */
$traitNames = array_map(static fn (BetterReflectionClass $trait): string => $trait->getName(), $traits);
$traitsByName = [];
foreach ($traits as $trait) {
/** @var trait-string $traitName */
$traitName = $trait->getName();
$traitsByName[$traitName] = new self($trait);
}

/** @psalm-suppress ImpureFunctionCall */
return array_combine(
$traitNames,
array_map(static fn (BetterReflectionClass $trait): self => new self($trait), $traits),
);
return $traitsByName;
}

/**
Expand Down
14 changes: 7 additions & 7 deletions src/Reflection/Adapter/ReflectionEnum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,14 +312,14 @@ public function getTraits(): array
{
$traits = $this->betterReflectionEnum->getTraits();

/** @var list<trait-string> $traitNames */
$traitNames = array_map(static fn (BetterReflectionClass $trait): string => $trait->getName(), $traits);
$traitsByName = [];
foreach ($traits as $trait) {
/** @var trait-string $traitName */
$traitName = $trait->getName();
$traitsByName[$traitName] = new ReflectionClass($trait);
}

/** @psalm-suppress ImpureFunctionCall */
return array_combine(
$traitNames,
array_map(static fn (BetterReflectionClass $trait): ReflectionClass => new ReflectionClass($trait), $traits),
);
return $traitsByName;
}

/** @return list<trait-string> */
Expand Down
14 changes: 7 additions & 7 deletions src/Reflection/Adapter/ReflectionObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,14 +316,14 @@ public function getTraits(): array
{
$traits = $this->betterReflectionObject->getTraits();

/** @var list<trait-string> $traitNames */
$traitNames = array_map(static fn (BetterReflectionClass $trait): string => $trait->getName(), $traits);
$traitsByName = [];
foreach ($traits as $trait) {
/** @var trait-string $traitName */
$traitName = $trait->getName();
$traitsByName[$traitName] = new ReflectionClass($trait);
}

/** @psalm-suppress ImpureFunctionCall */
return array_combine(
$traitNames,
array_map(static fn (BetterReflectionClass $trait): ReflectionClass => new ReflectionClass($trait), $traits),
);
return $traitsByName;
}

/**
Expand Down
Loading