-
-
Notifications
You must be signed in to change notification settings - Fork 82
Gesturefy v4 (Port to manifest v3) #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Robbendebiene
wants to merge
49
commits into
master
Choose a base branch
from
port-to-manifest-v3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 48 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
e8fef6a
Remove entire exclusion functionality
Robbendebiene eccea39
Minor code adjustments
Robbendebiene e8ccf64
Convert JSON config files to JS modules
Robbendebiene 470452e
Allow comma values for command font size
Robbendebiene 82cbf78
Replace png icons with svg icon
Robbendebiene 5009927
Redesign gesture search
Robbendebiene aba3162
Migrate manifest to version 3
Robbendebiene e0d7d40
Add deactivated icon
Robbendebiene 9ce0764
Migrate commands to new scripting API
Robbendebiene 31f3d81
Move data management actions to "extras" page
Robbendebiene f42af65
Make use of new background scripts module support
Robbendebiene 31ad7e4
Create separate data tab in options page
Robbendebiene 039ab36
Add initial browser action popup implementation
Robbendebiene 9d00bce
Add separate exclusion service
Robbendebiene b061df4
Move config manager to service directory
Robbendebiene 19300a7
Add host permission service and introduce base event listener service
Robbendebiene c1374b8
Display permission state in the browser action icon
Robbendebiene 7b55b05
Update exclusion service
Robbendebiene 27c9cfc
Improve host permission test function
Robbendebiene ac06d0c
Bring back exclusion functionality to content scripts
Robbendebiene 78b2d64
Fix restricted page warning
Robbendebiene 88194dc
Merge branch 'master' into port-to-manifest-v3
Robbendebiene a654ee5
Combine command functions and specification into new class format
Robbendebiene 7294876
Add orderable custom element
Robbendebiene 3eb04cf
Add collapsible custom element
Robbendebiene 2394c70
Replace custom clone function with native function
Robbendebiene ca2ad22
Add new command stack model
Robbendebiene 541b8a1
Improve collapsible-item custom element
Robbendebiene 0d832e6
Proxy command class to prevent default settings override
Robbendebiene 4ac7408
Rename collapsible-item file
Robbendebiene 9790cce
Rename file and fix orderable-collection
Robbendebiene 2d472a3
Add group attribute to collapsible-item
Robbendebiene 45e5246
Add reusable element builder function
Robbendebiene 13668b6
Add first iteration of new command picker
Robbendebiene 8d5a0fd
Add custom element to ease localization
Robbendebiene dcc1e30
Replace old collapse code with new collapsible-item
Robbendebiene aa5b1fa
Introduce a shared theme.css file
Robbendebiene 645652f
Migrate most px values to rem/em
Robbendebiene 7079709
Move and simplify fetchHTMLAsFragment function
Robbendebiene d6de0b4
Replace legacy module path builder with built-in resolver function
Robbendebiene 12e851b
Split code into custom pattern-preview element
Robbendebiene d4f4b01
Move code into a gesture card component
Robbendebiene 0bfd48e
Fix data section functionality
Robbendebiene 0a8c004
Multiple smaller corrections
Robbendebiene 0e2e6c9
Move all mouse gesture controller callbacks to the end of the executi…
Robbendebiene 2eac686
Add custom element pattern-recorder
Robbendebiene 96d35c0
Split command picker into two separate custom elements
Robbendebiene 3b20a70
Add form validation to custom elements
Robbendebiene 9654b26
Reworked gesture popup
Robbendebiene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
rg -n "navigationExclusions" --type=js --type=ts --type=json --type=htmlRepository: Robbendebiene/Gesturefy
Length of output: 2102
🏁 Script executed:
rg -n "navigationData|navigationExclusions" --type=js --type=ts --type=htmlRepository: Robbendebiene/Gesturefy
Length of output: 180
Navigation key rename from
navigationExclusionstonavigationDatais incomplete—only the English locale was updated.The code in
src/views/options/index.html:48references the new keynavigationData, andsrc/_locales/en/messages.jsonhas been updated accordingly. However, all 33 other locale files (de, fr, es_ES, it_IT, ja_JP, ko_KR, pt_BR, ru, zh_CN, zh_TW, etc.) still contain the oldnavigationExclusionskey. This will cause the extension to fail for non-English locales. Update all locale files to usenavigationDatainstead ofnavigationExclusions.🤖 Prompt for AI Agents