Fixes

Author: RobiNN1

src/Dashboards/Memcached/MemcachedTrait.php

@@ -401,7 +401,7 @@ private function commandsStats(): string {
     private function slabs(): string {
         $slabs_stats = $this->memcached->getSlabsStats();
 
-        $slabs = array_map(function (array $slab): array {
+        $slabs = array_map(static function (array $slab): array {
             $fields = [
                 'chunk_size'      => ['Chunk Size', 'bytes'],
                 'chunks_per_page' => ['Chunks per Page', 'number'],
@@ -420,7 +420,7 @@ private function slabs(): string {
                 'touch_hits'      => ['TOUCH Hits', 'number'],
             ];
 
-            return $this->formatField($fields, $slab);
+            return Helpers::formatFields($fields, $slab);
         }, $slabs_stats['slabs']);
 
         return $this->template->render('dashboards/memcached', [
@@ -435,7 +435,7 @@ private function slabs(): string {
     private function items(): string {
         $stats = $this->memcached->getItemsStats();
 
-        $items = array_map(function (array $item): array {
+        $items = array_map(static function (array $item): array {
             $fields = [
                 'number'                => ['Items', 'number'],
                 'number_hot'            => ['HOT LRU', 'number'],
@@ -468,29 +468,12 @@ private function items(): string {
                 'hits_to_temp'          => ['Hits to TEMP', 'number'],
             ];
 
-            return $this->formatField($fields, $item);
+            return Helpers::formatFields($fields, $item);
         }, $stats);
 
         return $this->template->render('dashboards/memcached', ['items' => $items]);
     }
 
-    /**
-     * @param array<string, mixed> $fields
-     * @param array<string, mixed> $item
-     *
-     * @return array<string, mixed>
-     */
-    private function formatField(array $fields, array $item): array {
-        $formatted = [];
-
-        foreach ($fields as $key => [$label, $type]) {
-            $value = $item[$key] ?? 0;
-            $formatted[$label] = Format::{$type}($value);
-        }
-
-        return $formatted;
-    }
-
     /**
      * @throws MemcachedException
      */

src/Helpers.php

@@ -241,4 +241,22 @@ public static function countChildren(array &$tree): int {
 
         return $count;
     }
+
+    /**
+     * @param array<string, mixed> $fields
+     * @param array<string, mixed> $item
+     *
+     * @return array<string, mixed>
+     */
+    public static function formatFields(array $fields, array $item): array {
+        $formatted = [];
+
+        // key_name => [label, formatting (number, bytes, seconds, time)]
+        foreach ($fields as $key => [$label, $type]) {
+            $value = $item[$key] ?? 0;
+            $formatted[$label] = $type !== '' ? Format::{$type}($value) : $value;
+        }
+
+        return $formatted;
+    }
 }