-
-
Notifications
You must be signed in to change notification settings - Fork 35
feat(v27): Async loading TypeScript by Integration
#3149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tic creator with loadPeer().
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe changes refactor TypeScript compilation API integration to use constructor-based dependency injection instead of dynamic loading, introduce a string-based identifier system to replace TypeScript Identifier objects throughout the codebase, and add an async factory pattern ( Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…criptAPI as a constructor argument.
bfe8bc0 to
2be687a
Compare
|
@coderabbitai please review |
|
@RobinTail, I'll review the changes in this PR for you. ✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed, but changelog and migration are requried
The better implementation of #3139 using the dynamic
import()instead ofcreateRequire().The new implementation requires either:
typescripttoIntegration::constructor()Integration::create()This is a breaking change.
typescriptbecomes an optional peer dependency. Documentation adjusted accordingly.Summary by CodeRabbit
Documentation
New Features
✏️ Tip: You can customize this high-level summary in your review settings.