Skip to content

Conversation

@ari-party
Copy link
Contributor

Changes

Remove Tolerance from OverlayParams in WorldRoot

image

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@ari-party ari-party requested a review from a team as a code owner February 6, 2025 20:57
@github-actions github-actions bot added engine reference Changes the Engine API Reference documentation changes requested This pull request has changes requested prior to merging labels Feb 6, 2025
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the following fields are editable: summary, description, deprecation_message. Other fields are automatically overwritten if edited. Please undo changes to the following fields:

  • methods.9.parameters.2.default
  • methods.10.parameters.2.default
  • methods.11.parameters.1.default

⛔️ This change is a requirement. Please fix it before merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right... Automatically generated yet it's incorrect...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ari-party , we're looking into this and why it's not synced with the actual default. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgnisRBX Different thing that's semi related, where can one best report wrong luau types?
1738995930_gHsEO3x6x9
(Should be Player?)

@github-actions
Copy link

This pull request has been inactive for 14 days. If it remains inactive for another 7 days, it will close. Please update or comment on this pull request to keep it open. 🙏

@github-actions github-actions bot added the stale label Feb 27, 2025
@github-actions
Copy link

github-actions bot commented Mar 7, 2025

This pull request has been inactive for 21 days. It's closing now. Please feel free to reopen it if you still need it. 🙏

@github-actions github-actions bot closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants