-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update MarketplaceService.yaml #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added/removed/moved a ton of things: moved product id to product section moved IconImageAssetId to asset section removed gamepass/dev products section (these items apply to all products and assets not just gamepasses/dev products) added seperate table for collectibles information with the appropriate fields moved sale location information to seperate table with more information fixed typos where "times" was instead typed as "items". Added TargetId to product section which wasn't present for some reason
|
For a few additions in the tables, you have a row with the note "(see following lines)" to indicate the fields within that table. But since the parent table name isn't prefixed onto any following lines, it's not clear which of the following lines are members of that table vs. the overall parent dictionary that's returned. Could you please specify which are members of tables as was done for the |
I made sure that all of the lines below the line with (see following lines) are parented to the table above. I see how this can be confusing so I'll change it. I just copied this formatting from the original page where a table field is described. |
Co-authored-by: IgnisRBX <[email protected]>
Added parent to name of fields belonging to an inner table.
|
I did a bit more formatting, opting to "indent" the fields that are part of a dictionary table. Could you quickly check again that everything looks accurate? Thanks! |
Looks good to me, although my preview doesn't show the exact format that the docs would have. There is some questionability between how the terms "item", "product", and "asset" are used both interchangeably and mutually exclusive, but I believe this is a problem outside the scope of just documentation. |

Changes
Added/removed/moved a ton of things for GetProductInfo():
With all this the page should now be consistent with the result of MarketplaceService:GetProductInfo():
Credit to @Valkenheim for a devforum post regarding the inconsistencies on this page, but this page was kind of a mess all around.
Checks
By submitting your pull request for review, you agree to the following: