Skip to content

Conversation

@RuizuKun-Dev
Copy link
Contributor

@RuizuKun-Dev RuizuKun-Dev commented Feb 28, 2025

game:GetService("Workspace") is unnecessary, workspace is global https://create.roblox.com/docs/reference/engine/globals/RobloxGlobals#workspace

I see no purpose of recommending that, using GetService for workspace is sacrilegious

Changes

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

game:GetService("Workspace") is unnecessary, workspace is global
https://create.roblox.com/docs/reference/engine/globals/RobloxGlobals#workspace

I see no purpose of recommending that
@RuizuKun-Dev RuizuKun-Dev requested a review from a team as a code owner February 28, 2025 03:07
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Feb 28, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RuizuKun-Dev, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

@riotschoolacc
Copy link

riotschoolacc commented Feb 28, 2025

For some reason, they insist on using the game GetService("Workspace"), but why is "workspace" global then??

@IgnisRBX
Copy link
Contributor

Fair point, all are valid and there's no absolutely compelling reason to recommend the first one, except that it matches the pattern of including other services. We can omit the "recommended" part here.

@IgnisRBX IgnisRBX merged commit 4f0b8ec into Roblox:main Feb 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine reference Changes the Engine API Reference documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants