Skip to content

Conversation

@foshesss
Copy link
Contributor

Changes

I was trying to figure out how to derive TextChatMessageProperites, and I couldn't find it anywhere. This PR aims to add a code snippet to the TextChatMessageProperties page ( https://create.roblox.com/docs/reference/engine/classes/TextChatMessageProperties ) that will show how to do so.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

@foshesss foshesss requested a review from a team as a code owner March 10, 2025 02:57
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Mar 10, 2025
@foshesss foshesss changed the title Added documentation for deriving TextChatMessageProperties Added code snippet for deriving TextChatMessageProperties Mar 10, 2025
@IgnisRBX
Copy link
Contributor

Hi @foshesss ,
Thanks for the contribution! Just real quick, check out the DeriveNewMessageProperties API description which recommends using the OnChatWindowAdded event, but your addition suggests using the OnIncomingMessage event. I'm not an extensive expert on using these events, so can you please explain if your example is the correct approach for deriving message properties vs. the example shown for ChatWindowConfiguration:DeriveNewMessageProperties()? Thanks!

https://create.roblox.com/docs/en-us/reference/engine/classes/ChatWindowConfiguration#DeriveNewMessageProperties

@foshesss
Copy link
Contributor Author

Hey @IgnisRBX . I appreciate the response. The code snippet aims to show how to derive TextChatMesssageProperties, and an example of using it. The only reason I used OnIncomingMessage in the PR as opposed to OnChatWindowAdded is consistency with the current page (it references OnIncomingMessage ). That being said, I agree that OnChatWindowAdded is a better example use case, and the page should include OnChatWindowAdded .

@foshesss
Copy link
Contributor Author

This looks good to me-- thanks Ignis!

@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label Mar 13, 2025
@IgnisRBX IgnisRBX merged commit 4e58a26 into Roblox:main Mar 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants