Clarity around the sender/receiver in ShouldDeliverCallback. #1050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Elaborated on the sender/receiver structure of
TextChannel.ShouldDeliverCallback. My co-worker got confused while he was working on a problem with us and thought the callback only gave you information about who sent the message, since in Play Solo you would be the only sender and recipient of the message. After confirming how I suspected it actually worked, I went in and made this documentation change so others hopefully don't have similar confusion in the future.Checks
By submitting your pull request for review, you agree to the following: